Repository navigation
Fix unattended inspection, incomplete reviews and model overrides - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the actual unattended execution path: thread/start used untrusted, so pinned Codex prompted for unmatched inspection commands while our RPC client rejected those approvals. Use never under the unchanged external Docker sandbox. Continue rejecting every client-side approval/tool/permission request; denied/missing inspection fails rather than becoming a clean review.
Require complete context and validate the exact head, structured review and changed-line locations inside the isolated entrypoint and again at the trusted host. Inconclusive/quarantined/truncated/incomplete results fail the job even when safe fallback recording succeeds. Keep separate protected COMMENT publication and all OIDC, credential, network, filesystem and merge boundaries.
Add the explicitly requested per-review --model override (both flag forms, quoting/order, catalog validation, selected-model effort validation, command > repository > default precedence). Existing snapshots remain compatible and model selection is included in the existing quota/idempotency path; no schema or permission change.
Validation: Node 24 check (148 tests/types/lint/build), independent clean checkout, real workerd/D1, 41 targeted execution/security/Worker tests, Actionlint, Docker image, audit/strict image scan and Wrangler dry-run. Actual Codex 0.169.0 code-mode exec executes file reads and isolation probes. Restoring only untrusted reproduces the blocked approval; never verifies exact diff/base/head/instruction bytes by nonce-specific hashes. Finding/clean/incomplete/no-inspection paths and safe separate publishing are covered.
Inference replies in Docker are scripted, so this does not claim live AI defect recognition. The opt-in real-provider harness now requires a valid changed-line finding on the same introduced authorization bug. It was not run: an authorized owner credential context and approved production rollout remain external acceptance gates. No paid inference, deployment, reconnect, secret change or merge performed.
Runner and Worker source both change. After normal approval/merge, use the actual merged source SHA in Worker trust + exact backend test and the protected caller; provisional pin drafts remain blocked until aligned. Keep automatic merge disabled and run fresh credential-only diagnostics before a separately authorized advisory review. No D1/session migration.